<html>
<head><meta charset="utf-8"><title>pass fake DefId&#x27;s to rustc APIs · rustdoc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/index.html">rustdoc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html">pass fake DefId&#x27;s to rustc APIs</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="236722746"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236722746" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236722746">(Apr 29 2021 at 18:31)</a>:</h4>
<p>Hey,<br>
I'm currently working on <a href="https://github.com/rust-lang/rust/issues/83183">#83183</a> and I set up the enum, and also removed the old hack.<br>
One of the main sources for the 280 errors that need to be fixed are </p>
<div class="codehilite"><pre><span></span><code>expected struct `rustc_span::def_id::DefId`, found enum `types::DefId`
</code></pre></div>
<p>Should I just put an <code>expect_real</code> there so that it panics when trying to pass a fake DefId?</p>
<p>Also, some more mentoring instructions would probably be helpful :) cc <span class="user-mention" data-user-id="232545">@Joshua Nelson</span> <br>
Currently, I'm doing most of this without knowing much about the rustdoc codebase</p>



<a name="236722872"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236722872" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236722872">(Apr 29 2021 at 18:32)</a>:</h4>
<p>oh wow that's amazing!</p>



<a name="236722928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236722928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236722928">(Apr 29 2021 at 18:32)</a>:</h4>
<blockquote>
<p>Should I just put an expect_real there so that it panics when trying to pass a fake DefId?</p>
</blockquote>
<p>ideally we would separate things into "known real" and to "possibly fake" fields</p>



<a name="236722954"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236722954" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236722954">(Apr 29 2021 at 18:32)</a>:</h4>
<p>can you give a couple examples of errors?</p>



<a name="236723361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236723361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236723361">(Apr 29 2021 at 18:34)</a>:</h4>
<p>Blindly translating things to .expect_real is probably ok for now though</p>



<a name="236723613"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236723613" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236723613">(Apr 29 2021 at 18:36)</a>:</h4>
<div class="codehilite" data-code-language="Rust"><pre><span></span><code><span class="c1">// src/librustdoc/passes/collect_trait_impls.rs:182:21</span>

<span class="bp">self</span><span class="p">.</span><span class="n">impls</span><span class="p">.</span><span class="n">extend</span><span class="p">(</span><span class="n">get_auto_trait_and_blanket_impls</span><span class="p">(</span><span class="w"></span>
<span class="w">    </span><span class="bp">self</span><span class="p">.</span><span class="n">cx</span><span class="p">,</span><span class="w"></span>
<span class="w">    </span><span class="bp">self</span><span class="p">.</span><span class="n">cx</span><span class="p">.</span><span class="n">tcx</span><span class="p">.</span><span class="n">type_of</span><span class="p">(</span><span class="n">i</span><span class="p">.</span><span class="n">def_id</span><span class="p">.</span><span class="n">expect_real</span><span class="p">()),</span><span class="w"></span>
<span class="w">    </span><span class="n">i</span><span class="p">.</span><span class="n">def_id</span><span class="p">,</span><span class="w"></span>
<span class="p">));</span><span class="w"></span>
</code></pre></div>
<p>is one example. It's hard to find "real" ones because most of the errors can be easily fixed by importing <code>clean::DefId</code> instead of <code>rustc_hir::DefId</code></p>



<a name="236723708"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236723708" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236723708">(Apr 29 2021 at 18:37)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/266220-rustdoc/topic/pass.20fake.20DefId's.20to.20rustc.20APIs/near/236723361">said</a>:</p>
<blockquote>
<p>Blindly translating things to .expect_real is probably ok for now though</p>
</blockquote>
<p>Alright, I will start with that.</p>



<a name="236724274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236724274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236724274">(Apr 29 2021 at 18:41)</a>:</h4>
<p>That one looks correct to call expect_real() on, no fake ids at all are generated before get_auto_and_blanket_impls()</p>



<a name="236724357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236724357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236724357">(Apr 29 2021 at 18:41)</a>:</h4>
<p>Hmm I wonder if it makes sense to have only things in that impls field use fake ids</p>



<a name="236724430"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236724430" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236724430">(Apr 29 2021 at 18:42)</a>:</h4>
<p>And parameterize Item on the id or something</p>



<a name="236724729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236724729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236724729">(Apr 29 2021 at 18:44)</a>:</h4>
<blockquote>
<p>Also, some more mentoring instructions would probably be helpful :) cc @Joshua Nelson </p>
</blockquote>
<p>I'll be honest, most of the work here is designing what the API <em>should</em> look like</p>



<a name="236726474"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236726474" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236726474">(Apr 29 2021 at 18:56)</a>:</h4>
<p>I'm going to assign you on the issue so other people don't try to work on it at the same time, no pressure though - even if you only get halfway that's still useful :)</p>



<a name="236726533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236726533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236726533">(Apr 29 2021 at 18:57)</a>:</h4>
<p>Ah yes. forgot that. Thanks</p>



<a name="236729239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236729239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236729239">(Apr 29 2021 at 19:14)</a>:</h4>
<p>I opened <a href="https://github.com/rust-lang/rust/pull/84707">#84707</a> to track the progress <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="236729476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236729476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236729476">(Apr 29 2021 at 19:16)</a>:</h4>
<p><span class="user-mention" data-user-id="230287">@Stu</span> looks like you based it off an old branch - you might want to rebase that before fixing everything</p>



<a name="236729562"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236729562" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236729562">(Apr 29 2021 at 19:16)</a>:</h4>
<p>ah yea, I forgot to update my rust fork</p>



<a name="236729664"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236729664" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236729664">(Apr 29 2021 at 19:17)</a>:</h4>
<p>oh wow yeah that's from january haha</p>



<a name="236729872"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236729872" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236729872">(Apr 29 2021 at 19:19)</a>:</h4>
<p>oh wow. whoops. That will be <em>fun</em> to rebase</p>



<a name="236732976"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236732976" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236732976">(Apr 29 2021 at 19:40)</a>:</h4>
<p>ah nice. ICE while running <code>./x.py check</code>. Incremental compilation didn't like the rebase I guess</p>



<a name="236733171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236733171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236733171">(Apr 29 2021 at 19:42)</a>:</h4>
<p>lol nice, was it an "unstable predicates" crash?</p>



<a name="236733234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236733234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236733234">(Apr 29 2021 at 19:42)</a>:</h4>
<p>you can fix that with <code>rm -r build/$TARGET/stage0-rustc/release/incremental</code></p>



<a name="236733286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236733286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236733286">(Apr 29 2021 at 19:42)</a>:</h4>
<p>Yeah, <code>found unstable fingerprints for predicates_of</code></p>
<p>I just ran <code>clean</code> <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="236733303"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236733303" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236733303">(Apr 29 2021 at 19:42)</a>:</h4>
<p>oh oof</p>



<a name="236733383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236733383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236733383">(Apr 29 2021 at 19:43)</a>:</h4>
<p>btw if you wait to make the rustc changes for a later commit, you can use download-rustc instead which takes way less time</p>



<a name="236733728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236733728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236733728">(Apr 29 2021 at 19:46)</a>:</h4>
<p>oh thats awesome, but I get the same NixOS error you opened an issue about</p>



<a name="236733824"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236733824" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236733824">(Apr 29 2021 at 19:46)</a>:</h4>
<p>you  can fix that by copy/pasting the command and replacing ci-rustc with stage0</p>



<a name="236842274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236842274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236842274">(Apr 30 2021 at 14:25)</a>:</h4>
<p><span class="user-mention silent" data-user-id="230287">Stu</span> <a href="#narrow/stream/266220-rustdoc/topic/pass.20fake.20DefId's.20to.20rustc.20APIs/near/236733728">said</a>:</p>
<blockquote>
<p>oh thats awesome, but I get the same NixOS error you opened an issue about</p>
</blockquote>
<p><span class="user-mention" data-user-id="230287">@Stu</span> fyi: <a href="https://github.com/rust-lang/rust/pull/84750">https://github.com/rust-lang/rust/pull/84750</a></p>



<a name="236842367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236842367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236842367">(Apr 30 2021 at 14:26)</a>:</h4>
<p>you can cherry-pick that to have cargo fixed automatically (although you shouldn't run into this again until the beta bump or you clear your build cache)</p>



<a name="236858682"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236858682" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236858682">(Apr 30 2021 at 16:00)</a>:</h4>
<p>finally, first module done <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="236860532"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236860532" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236860532">(Apr 30 2021 at 16:12)</a>:</h4>
<p>only 150 errors left <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="236860578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236860578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236860578">(Apr 30 2021 at 16:13)</a>:</h4>
<p>oh boy</p>



<a name="236953967"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236953967" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236953967">(May 01 2021 at 09:47)</a>:</h4>
<p>Finally, everything compiles <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="236954356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236954356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236954356">(May 01 2021 at 09:55)</a>:</h4>
<p><a href="/user_uploads/4715/Las6LhEUdJjyKSbwRgNFkTCR/image.png">Test Result</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/Las6LhEUdJjyKSbwRgNFkTCR/image.png" title="Test Result"><img src="/user_uploads/4715/Las6LhEUdJjyKSbwRgNFkTCR/image.png"></a></div><p>Whoops</p>



<a name="236961990"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236961990" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236961990">(May 01 2021 at 12:05)</a>:</h4>
<p>Test suite passes <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span> </p>
<p>Should be ready for review</p>



<a name="236972493"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236972493" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236972493">(May 01 2021 at 14:35)</a>:</h4>
<p>That's incredible</p>



<a name="236972496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236972496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236972496">(May 01 2021 at 14:35)</a>:</h4>
<p>Wow</p>



<a name="236976964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236976964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236976964">(May 01 2021 at 15:23)</a>:</h4>
<p>holy shit I'm hitting <a href="https://github.com/rust-lang/rust/issues/84702">this</a> so often</p>



<a name="236979675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/pass%20fake%20DefId%27s%20to%20rustc%20APIs/near/236979675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/pass.20fake.20DefId&#x27;s.20to.20rustc.20APIs.html#236979675">(May 01 2021 at 16:05)</a>:</h4>
<p><span class="user-mention" data-user-id="230287">@Stu</span> the fix was approved if you want to cherry pick the commit, git can handle it</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>